maple/istoreos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kernel: ledtrig-netdev: fix carrier status check

Browse Source 
Referring to carrier_show in net/core/net-sysfs.c,
we can see that netif_carrier_ok is only meaningful on netif_running.

Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
This commit is contained in:
Liangbin Lian 2025-01-02 19:45:46 +08:00
parent 21e285bb5b
commit 0e8c395643
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
target/linux/generic/hack-6.6/802-ledtrig-netdev-fix-carrier-status-check.patch Normal file
View File

@ -0,0 +1,24 @@
From b09e2f05ea1d740403397a55dd8e59ad637554e5 Mon Sep 17 00:00:00 2001
From: Liangbin Lian <jjm2473@gmail.com>
Date: Tue, 26 Dec 2023 17:10:08 +0800
Subject: [PATCH] ledtrig-netdev: fix carrier status check
Referring to carrier_show in net/core/net-sysfs.c,
we can see that netif_carrier_ok is only meaningful on netif_running.
Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
---
drivers/leds/trigger/ledtrig-netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/leds/trigger/ledtrig-netdev.c
+++ b/drivers/leds/trigger/ledtrig-netdev.c
@@ -207,7 +207,7 @@ static void get_device_state(struct led_
{
struct ethtool_link_ksettings cmd;
- trigger_data->carrier_link_up = netif_carrier_ok(trigger_data->net_dev);
+ trigger_data->carrier_link_up = netif_running(trigger_data->net_dev) && netif_carrier_ok(trigger_data->net_dev);
if (!trigger_data->carrier_link_up)
return;