From 773825c18e66658540e41ac4ca6a8d7de1ee545a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0tetiar?= Date: Mon, 6 Mar 2023 19:24:43 +0100 Subject: [PATCH] scripts: gen_config.py: install additional_packages in one go MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To avoid quite costly parsing step on each additional package install. Signed-off-by: Petr Štetiar --- scripts/gen_config.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/gen_config.py b/scripts/gen_config.py index 6876644724..358ba9935a 100755 --- a/scripts/gen_config.py +++ b/scripts/gen_config.py @@ -157,11 +157,11 @@ for p in profile.get("feeds", []): for ap in profile.get("additional_packages"): feed = ap["feed"] - for package in ap["packages"]: - if run_cmd( - ["./scripts/feeds", "install", "-f", "-p", feed, package] - ).returncode: - die(f"Error installing additional package {package} from {feed} feed") + if run_cmd( + ["./scripts/feeds", "install", "-f", "-p", feed, *ap["packages"]] + ).returncode: + packages_install = " ".join(ap["packages"]) + die(f"Error installing additional packages {packages_install} from {feed} feed") if profile.get("external_target", False): if run_cmd(["./scripts/feeds", "install", profile["target"]]).returncode: