From 95497de33145c35872c25fbc7a4c574c7ee655bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0tetiar?= Date: Tue, 4 Mar 2025 19:59:06 +0000 Subject: [PATCH] ci: mark tests which could fail as allowed to fail to maintain green CI status MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently we're seeing a bit confusing workflow, where merge requests with failed (red) CI pipeline are being merged. This is caused by the fact, that sometimes we run additional tests on CI testing platforms like Haze/Turris, which are not properly maintained due to limited resources, so it takes a bit more time to fix those CI tests. Sometimes we run test cases which are work in progress, like the prpl Certification or pending fixes delivery like UPnP. It doesn't mean, that there is necessarily something wrong with the contribution under the test. We're just making sure, that no new regressions are being introduced or for example, when adding new tests, that they're generic enough and works across the boards. So lets improve the situation and mark such test cases as allowed to fail, so once we use them in the pipeline for internal testing purposes, their result doesn't influence the resulting pipeline status and thus we would be merging contributions with possibly only OK (green) CI pipeline. Suggested-by: Frederik Van Bogaert Signed-off-by: Petr Štetiar --- .gitlab-ci.yml | 2 ++ .gitlab/cdrouter/mxl25641-hdk-6.yml | 2 ++ .gitlab/cdrouter/prpl-haze.yml | 2 +- .gitlab/cdrouter/turris-omnia.yml | 2 +- .gitlab/cdrouter/urx851-hdk-3.yml | 2 ++ .gitlab/cdrouter/wnc-freedom.yml | 2 ++ 6 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e6b860fbdc..ae3d476cf6 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -74,12 +74,14 @@ coverity scan ipq807x prpl: aarch64-openwrt-linux-musl-gcc run test Turris Omnia initramfs: + allow_failure: true needs: - job: build test mvebu prpl security optional: true extends: .turris-omnia testbed run test Haze initramfs: + allow_failure: true needs: - job: build test ipq807x prpl security optional: true diff --git a/.gitlab/cdrouter/mxl25641-hdk-6.yml b/.gitlab/cdrouter/mxl25641-hdk-6.yml index 3671f50952..e0cb25079e 100644 --- a/.gitlab/cdrouter/mxl25641-hdk-6.yml +++ b/.gitlab/cdrouter/mxl25641-hdk-6.yml @@ -72,6 +72,7 @@ CDRouter-IPv6-Top-100+mDNS MXL25641-HDK-6 eMMC: prpl-Certification MXL25641-HDK-6 eMMC: <<: *mxl25641_cdrouter_ipv6 + allow_failure: true rules: - if: '$CI_PIPELINE_SOURCE == "schedule"' when: never @@ -107,6 +108,7 @@ CDRouter-TR-069 MXL25641-HDK-6 eMMC: CDRouter-USP-prpl MXL25641-HDK-6 eMMC: <<: *mxl25641_cdrouter + allow_failure: true rules: - if: '$CI_PIPELINE_SOURCE == "schedule"' when: never diff --git a/.gitlab/cdrouter/prpl-haze.yml b/.gitlab/cdrouter/prpl-haze.yml index 95be5530fd..4a74d9b9e5 100644 --- a/.gitlab/cdrouter/prpl-haze.yml +++ b/.gitlab/cdrouter/prpl-haze.yml @@ -1,4 +1,5 @@ .prpl-haze: &prpl_haze + allow_failure: true rules: - if: '$CI_PIPELINE_SOURCE == "schedule"' when: never @@ -62,7 +63,6 @@ CDRouter-Wireless Haze initramfs: CDRouter-UPnP-IPv46 Haze initramfs: <<: *prpl_haze_ipv6 - allow_failure: true variables: CDROUTER_TEST_CONFIG: generic-ipv6-upnp DUT_INIT_SCRIPTS: | diff --git a/.gitlab/cdrouter/turris-omnia.yml b/.gitlab/cdrouter/turris-omnia.yml index f0b1d8bca5..d35e086ad9 100644 --- a/.gitlab/cdrouter/turris-omnia.yml +++ b/.gitlab/cdrouter/turris-omnia.yml @@ -1,4 +1,5 @@ .turris-cdrouter: &turris_cdrouter + allow_failure: true needs: - job: build test mvebu prpl security optional: true @@ -62,7 +63,6 @@ CDRouter-Wireless Turris initramfs: CDRouter-UPnP-IPv46 Turris initramfs: <<: *turris_cdrouter_ipv6 - allow_failure: true variables: CDROUTER_TEST_CONFIG: generic-ipv6-upnp DUT_INIT_SCRIPTS: | diff --git a/.gitlab/cdrouter/urx851-hdk-3.yml b/.gitlab/cdrouter/urx851-hdk-3.yml index 15a1edc922..a4b8be74b8 100644 --- a/.gitlab/cdrouter/urx851-hdk-3.yml +++ b/.gitlab/cdrouter/urx851-hdk-3.yml @@ -70,6 +70,7 @@ CDRouter-IPv6-Top-100+mDNS URX851-HDK-3 eMMC: prpl-Certification URX851-HDK-3 eMMC: <<: *urx851_cdrouter_ipv6 + allow_failure: true rules: - if: '$CI_PIPELINE_SOURCE == "schedule"' when: never @@ -105,6 +106,7 @@ CDRouter-TR-069 URX851-HDK-3 eMMC: CDRouter-USP-prpl URX851-HDK-3 eMMC: <<: *urx851_cdrouter + allow_failure: true rules: - if: '$CI_PIPELINE_SOURCE == "schedule"' when: never diff --git a/.gitlab/cdrouter/wnc-freedom.yml b/.gitlab/cdrouter/wnc-freedom.yml index 17ca5477e5..778cd70581 100644 --- a/.gitlab/cdrouter/wnc-freedom.yml +++ b/.gitlab/cdrouter/wnc-freedom.yml @@ -72,6 +72,7 @@ CDRouter-IPv6-Top-100+mDNS Freedom initramfs: prpl-Certification Freedom initramfs: <<: *wnc_freedom_ipv6 + allow_failure: true rules: - if: '$CI_PIPELINE_SOURCE == "schedule"' when: never @@ -110,6 +111,7 @@ CDRouter-TR-069 Freedom eMMC: CDRouter-USP-prpl Freedom initramfs: <<: *wnc_freedom + allow_failure: true rules: - if: '$CI_PIPELINE_SOURCE == "schedule"' when: never